Author Topic: ObjectBrokerClient::usePacket  (Read 4105 times)

Sequoh

  • User
  • *
  • Posts: 2
ObjectBrokerClient::usePacket
« on: April 29, 2006, 12:59:41 PM »
After resurrecting an old project using GNE, I've come across an issue in the ObjectBrokerClient implementation (CVS version):

According to the documentation 'ignoreUpdateError' is useful for avoiding exceptions being thrown when update packets arrive before their creation packets.
However, it doesn't do what it's supposed to do and throws anyway.

It's a simple fix, I just wanted to bring it to your attention. Also, I'd consider splitting the usePacket function into three seperate functions, since client code must (?) check the packet id to see if it's one of the ObjectBroker packets anyway before passing it to the OBClient.

Thanks for a modern networking library! :)

Sequoh

  • User
  • *
  • Posts: 2
GNE::Time::operator !=
« Reply #1 on: May 22, 2006, 06:18:02 AM »
There's a slight typo in the CVS version of GNE::Time::operator !=

Line 99:
  return (microsec != rhs.microsec || sec != rhs.microsec);

should of course read

  return (microsec != rhs.microsec || sec != rhs.sec);

Gillius

  • Administrator
  • User
  • *****
  • Posts: 147
    • http://www.gillius.org/
ObjectBrokerClient::usePacket
« Reply #2 on: May 22, 2006, 08:43:36 AM »
Yep, you are right.  I will check that in in the next couple of days.
Gillius
Gillius's Programming http://www.gillius.org/

Gillius

  • Administrator
  • User
  • *****
  • Posts: 147
    • http://www.gillius.org/
ObjectBrokerClient::usePacket
« Reply #3 on: May 22, 2006, 11:45:58 PM »
I checked in that change:

Code: [Select]

99c99
<   return (microsec != rhs.microsec || sec != rhs.microsec);
---
>   return (microsec != rhs.microsec || sec != rhs.sec);
Gillius
Gillius's Programming http://www.gillius.org/